Fix app map messages on mobile #4712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The container of the messages in the mobile apps were partially rendered on top of the measure tools, which resulted in some of the buttons not working. To fix this, the container is moved up in this patch.
I've noticed an other issue while working on that. There was an extra message being shown, a link saying that "you're in the mobile version, go in the desktop version" which was hidden using opacity to 0. That means that you were able to click on the link even if you couldn't see it and end up in an other page. I think this could be considered as a bug. Also, it left a big empty gap as well.
Instead of the opacity, I made it invisible using display:none only if it should be hidden.