Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Waiting cursor for map query [2.3] #4852

Closed

Conversation

pfirpfel
Copy link
Contributor

I wanted to show a different cursor if there is a pending map query. But query/windowComponent (formerly displayquerywindow) keeps clearing ngeoQueryResult right after MapQuerent.issue() gets called. This clearing is not distinguishable from a unsuccessful query.

For my feature, I need the first commit in ngeo (the one that removes the clear). GMF seems to work fine without it.

The second commit is the cursor feature, which does not need to be part of gmf.

@pfirpfel pfirpfel requested review from fredj and sbrunner April 26, 2019 14:00
@pfirpfel pfirpfel self-assigned this Apr 26, 2019
@pfirpfel pfirpfel force-pushed the waiting-cursor-for-map-query-2.3 branch from dcf7daf to 3232f90 Compare April 26, 2019 14:17
@sbrunner sbrunner added this to the 2.3 milestone Apr 30, 2019
@pfirpfel
Copy link
Contributor Author

pfirpfel commented May 1, 2019

@fredj
Since you did not question the feature itself, I have to add more thoughts. I'm not sure, if the code is at the right place in the controller of the demo desktop app.
I tried putting it in the abstract desktop controller (makes no sense on mobile?), but that abstract controller was loaded before ngeoQueryResult was initialized. That's why it is there right now in the demo app...

Would it be possible to do this in the abstract desktop controller?

Moving it there would make it a default feature, is this even a desired outcome?

Alternatively, I could move id to the desktop_alt demo app. This is more the home of those weird non-default features. Having it in the regular desktop app could create wrong expectations from clients, since it would not available by default.

@pfirpfel
Copy link
Contributor Author

pfirpfel commented May 9, 2019

Moved the bugfix to new PR #4887

Will implement the waiting cursor as a custom feature.

@pfirpfel pfirpfel closed this May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants