Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ESLint Plugin TypeScript #4970

Merged
merged 2 commits into from Jun 27, 2019
Merged

Add ESLint Plugin TypeScript #4970

merged 2 commits into from Jun 27, 2019

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner added this to the 2.5 milestone Jun 25, 2019
@sbrunner sbrunner force-pushed the more-typecheck branch 3 times, most recently from 1d82d56 to e1a3e7c Compare June 25, 2019 13:11
@sbrunner sbrunner marked this pull request as ready for review June 25, 2019 13:27
@sbrunner sbrunner requested a review from fredj June 25, 2019 13:27
gberaudo
gberaudo reviewed Jun 27, 2019
View reviewed changes
contribs/gmf/src/raster/component.js Outdated
@@ -109,6 +109,7 @@ function rasterComponent() {
'layer': '<gmfElevationLayer',
'map': '=gmfElevationMap'
},
// @ts-ignore
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why these ts-ignore?

@sbrunner sbrunner merged commit aabdba7 into master Jun 27, 2019
@sbrunner sbrunner deleted the more-typecheck branch June 27, 2019 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

@gberaudo gberaudo gberaudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sbrunner @fredj @gberaudo