Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better errors behavior #5000

Merged
merged 2 commits into from
Jul 10, 2019
Merged

Better errors behavior #5000

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b83b133
Catch page load error
sbrunner Jul 10, 2019
e4f38f2
Add global catch
sbrunner Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions buildtools/check-example.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,12 @@ function loaded(page, browser) {
process.exit(2);
}
});
await page.goto(url);
await page.goto(url).catch(error => {
console.log(`Page load error: ${error}.`);
process.exit(2);
});
loaded(page, browser);
})();
})().catch(error => {
console.log(`Unexpected error: ${error}.`);
process.exit(2);
});