Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduces swipe component to desktop alt #5081

Merged
merged 6 commits into from
Sep 4, 2019
Merged

Introduces swipe component to desktop alt #5081

merged 6 commits into from
Sep 4, 2019

Conversation

RBcote
Copy link
Contributor

@RBcote RBcote commented Aug 22, 2019 •
edited

Introduces layer being swipe into desktop alt.

@RBcote RBcote requested a review from adube August 22, 2019 17:05
@adube adube changed the base branch from master to T9027-3-swipe-component August 22, 2019 17:14
@sbrunner sbrunner changed the title T9027 4 swipe component Wwipe component Aug 23, 2019
@sbrunner sbrunner changed the title Wwipe component Swipe component Aug 23, 2019
sbrunner
sbrunner reviewed Aug 23, 2019
View reviewed changes
src/map/swipe.js Outdated Show resolved Hide resolved
@adube adube changed the title Swipe component WIP Swipe component integration in GMF apps Aug 23, 2019
@RBcote RBcote changed the base branch from T9027-3-swipe-component to T9027-2-swipe-component August 26, 2019 15:40
@RBcote RBcote changed the title WIP Swipe component integration in GMF apps Introduces swipe component to desktop alt Aug 26, 2019
adube
adube suggested changes Aug 27, 2019
View reviewed changes
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments.

contribs/gmf/src/layertree/component.js Outdated Show resolved Hide resolved
contribs/gmf/src/layertree/component.html Outdated Show resolved Hide resolved
contribs/gmf/src/layertree/component.html Outdated Show resolved Hide resolved
contribs/gmf/src/layertree/component.js Show resolved Hide resolved
contribs/gmf/src/layertree/component.js Outdated Show resolved Hide resolved
contribs/gmf/src/layertree/component.js Show resolved Hide resolved
@RBcote
Copy link
Contributor Author

RBcote commented Aug 27, 2019

How can i fix those errors from Travis ;
contribs/gmf/src/layertree/component.js(836,7): error TS2322: Type 'LayerGroup | Layer | null' is not assignable to type 'TileLayer'.
contribs/gmf/src/layertree/component.js(834,5): error TS2322: Type 'null' is not assignable to type 'TileLayer'.

adube
adube suggested changes Aug 27, 2019
View reviewed changes
contribs/gmf/apps/desktop_alt/index.html.ejs Outdated Show resolved Hide resolved
contribs/gmf/src/layertree/component.js Outdated Show resolved Hide resolved
@adube
Copy link
Contributor

adube commented Aug 27, 2019

@sbrunner Please, check the errors reported by RCote / Travis.

@sbrunner sbrunner added this to the dummy milestone Sep 2, 2019
@adube
Copy link
Contributor

adube commented Sep 3, 2019

@sbrunner Please, review.

sbrunner
sbrunner approved these changes Sep 4, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ...

@RBcote RBcote merged commit 2c85be2 into T9027-2-swipe-component Sep 4, 2019
@fredj fredj deleted the T9027-4-swipe-component branch September 17, 2019 06:46
@fredj fredj mentioned this pull request Sep 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@adube adube adube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
dummy
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@RBcote @adube @sbrunner