Improve snapping #5084
Merged
Improve snapping #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnaud-morvan
force-pushed
the
gsgmf-1035-improve_snapping
branch
from
844ae79
to
8d51078
Compare
|
Note that this works perfectly now, so we might merge this and consider layertree refactoring later. |
arnaud-morvan
force-pushed
the
gsgmf-1035-improve_snapping
branch
3 times, most recently
from
6060766
to
d95e91f
Compare
sbrunner
reviewed
Aug 26, 2019
arnaud-morvan
force-pushed
the
gsgmf-1035-improve_snapping
branch
from
d95e91f
to
7353704
Compare
sbrunner
reviewed
Aug 26, 2019
arnaud-morvan
force-pushed
the
gsgmf-1035-improve_snapping
branch
2 times, most recently
from
e2bc11a
to
e9000e8
Compare
|
On the example it seem that the activation and the deactivation don't work... |
arnaud-morvan
force-pushed
the
gsgmf-1035-improve_snapping
branch
from
e9000e8
to
89c0d84
Compare
|
Yes, fixed, hope everything is good now. |
|
+1 Thanks, @fredj can you have a second look? |
|
@fredj : This PR is ready for merge, do you want to have a look before ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.camptocamp.com/browse/GSGMF-1035
Test link : https://camptocamp.github.io/ngeo/gsgmf-1035-improve_snapping/examples/contribs/gmf/apps/desktop_alt.html?dim_FLOOR=*&lang=fr&tree_groups=Edit%2CSnapping%2CSnapping%20tollerance%2CSnapping%20no%20edge%2CSnapping%20no%20vertex&baselayer_ref=OSM%20map&baselayer_opacity=100&tree_group_layers_Snapping%20tollerance=Snapping%20tollerance%2Cpoint%20snap%20tolerance%2Cline%20snap%20tolerance%2Cpolygon%20snap%20tolerance
Activate or deactivate snapping on some layers and give a try to "Draw and measure".