Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix filter attributes #5108

Merged
merged 3 commits into from Sep 10, 2019
Merged

Fix filter attributes #5108

merged 3 commits into from Sep 10, 2019

Conversation

llienher
Copy link
Member

@llienher llienher commented Sep 6, 2019 •
edited

@llienher llienher self-assigned this Sep 6, 2019
@sbrunner
Copy link
Member

sbrunner commented Sep 6, 2019

@fredj do you agree with the second commit that disable strictNullChecks?

@sbrunner sbrunner force-pushed the fix-attributes branch 2 times, most recently from abf1458 to 0ff41d7 Compare September 6, 2019 15:55
@sbrunner
Copy link
Member

sbrunner commented Sep 6, 2019

For CI see:
openlayers/openlayers#9888
openlayers/openlayers#9897
...

@sbrunner sbrunner merged commit d317163 into master Sep 10, 2019
@llienher llienher deleted the fix-attributes branch September 10, 2019 09:04
@sbrunner sbrunner added this to the 2.5 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

@sbrunner sbrunner sbrunner approved these changes

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@llienher @sbrunner @fredj