Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to change the logo in the simple project #5111

Merged
merged 1 commit into from Sep 18, 2019
Merged

Be able to change the logo in the simple project #5111

merged 1 commit into from Sep 18, 2019

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner added this to the 2.5 milestone Sep 10, 2019
Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with Chromium, "By camptocamp appears on two lines", so "Camptocamp" is over Zoom+ button.
Why such a complexity, all display perfectly with just:

.logo {
  background-image: url('./logo.png');
  background-repeat: no-repeat;
  background-size: auto $topbar-height;
  padding-left: 19rem;
}

And other coming elements will take correct position without any imperative positionning.

How about other interfaces (mobile, desktop_alt, etc) ?

@sbrunner
Copy link
Member Author

I will try :-)

Mobile has no header bar, I will also migrate desktop_alt and oe_edit :-)

@sbrunner
Copy link
Member Author

Simplify, also test other desktop interfaces :-)

Copy link
Member

@arnaud-morvan arnaud-morvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants