Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace query directives by new component #5116

Merged
merged 2 commits into from Sep 18, 2019

Conversation

adube
Copy link
Contributor

@adube adube commented Sep 12, 2019

GSGMF 1047 - phase 2

This patch is the second step towards implementing a new way to query the map by drawing polygons.

This patch:

  • changes all examples (ngeo, gmf) and applications (gmf) to use the new <ngeo-query> component instead of the two ngeo mapquery and bboxquery directives
  • removes the code of the 2 directives no longer used
  • removes 2 ngeo examples: mapquery and bboxquery

@adube adube force-pushed the gsgmf-1047-2-remove-old-query-stuff branch 3 times, most recently from 553f25d to 8cec493 Compare September 17, 2019 14:20
@adube adube force-pushed the gsgmf-1047-2-remove-old-query-stuff branch from 8cec493 to fb3c88e Compare September 17, 2019 14:37
@adube adube changed the title WIP - Replace query directives by new component Replace query directives by new component Sep 17, 2019
@adube adube requested a review from fredj September 17, 2019 14:37
@adube
Copy link
Contributor Author

adube commented Sep 17, 2019

@fredj Ready for review.

@adube adube force-pushed the gsgmf-1047-2-remove-old-query-stuff branch from e0dd729 to d3d02c8 Compare September 18, 2019 12:47
@adube adube merged commit c4fbf56 into camptocamp:master Sep 18, 2019
@adube adube deleted the gsgmf-1047-2-remove-old-query-stuff branch September 18, 2019 13:21
@sbrunner sbrunner added this to the 2.5 milestone Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants