Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Press escape to desactivate drawing in edition #5129

Merged
merged 2 commits into from Sep 24, 2019
Merged

Press escape to desactivate drawing in edition #5129

merged 2 commits into from Sep 24, 2019

Conversation

llienher
Copy link
Member

@llienher llienher self-assigned this Sep 19, 2019
@llienher llienher force-pushed the GSEPF-259_escape-cancelation-draw branch from 3759f05 to 738fb6e Compare September 20, 2019 06:50
@llienher llienher force-pushed the GSEPF-259_escape-cancelation-draw branch 2 times, most recently from 37826bb to d70e102 Compare September 23, 2019 09:27
@llienher llienher force-pushed the GSEPF-259_escape-cancelation-draw branch from d70e102 to 25d50f4 Compare September 23, 2019 09:48
gberaudo
gberaudo reviewed Sep 23, 2019
View reviewed changes
src/draw/Controller.js Outdated Show resolved Hide resolved
@llienher llienher force-pushed the GSEPF-259_escape-cancelation-draw branch from f91e575 to 72fc345 Compare September 23, 2019 15:07
@sbrunner
Copy link
Member

Is it relay without risque to merge it on a stable branch?

@gberaudo
Copy link
Member

Is it relay without risk to merge it on a stable branch?

@sbrunner, this is a new functionality that triggers only when the "esc" key is pressed.
Since that key does nothing at the moment the users will not notice the change.
So risk is low IMO.

@llienher llienher merged commit 547a053 into 2.3 Sep 24, 2019
@llienher llienher deleted the GSEPF-259_escape-cancelation-draw branch September 24, 2019 08:36
@sbrunner
Copy link
Member

Should be merged on 2.4 and master :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj left review comments

@gberaudo gberaudo gberaudo approved these changes

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@llienher @sbrunner @gberaudo @fredj