Clear login and password after successful login #5165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks that it should be rebased... |
And clear password fields after failed attempts
arnaud-morvan
force-pushed
the
GSGMF-1065-clear-password-after-login
branch
from
a0b4f38
to
ae36d3c
Compare
|
Well spotted, missing an approve now. |
|
For me that's looks good, @fredj can you have a second look? |
fredj
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And clear password fields after failed attempts.
https://jira.camptocamp.com/browse/GSGMF-1065
Note that after password change, fields are already cleared.