Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix swiper styling issues. #5185

Merged
merged 3 commits into from Oct 7, 2019
Merged

Fix swiper styling issues. #5185

merged 3 commits into from Oct 7, 2019

Conversation

RBcote
Copy link
Contributor

@RBcote RBcote commented Oct 1, 2019 •
edited by fredj

This patch fix styling issues;

  1. The vertical swiper is working on Windows Firefox.
  2. The vertical bar is correctly positionned on the limit.
  3. The vertical bar touch the top of the map.

https://camptocamp.github.io/ngeo/T9224-1-mapswipe-firefox/examples/contribs/gmf/apps/desktop.html

@RBcote RBcote requested a review from adube October 1, 2019 13:10
adube
adube suggested changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The swipe component now behaves properly in Firefox, however the interactivity with the map no longer works (Chrome, Firefox).

Please, fix.

adube
adube approved these changes Oct 1, 2019
View reviewed changes
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is now working properly. Let's ask @fredj to review and let's merge after he accepts.

@adube adube requested a review from fredj October 1, 2019 18:07
@sbrunner sbrunner added this to the 2.5 milestone Oct 4, 2019
fredj
fredj approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, thanks

@fredj
Copy link
Member

fredj commented Oct 7, 2019

Merging so @ybolognini can start testing

@fredj fredj merged commit 84947e3 into master Oct 7, 2019
@fredj fredj deleted the T9224-1-mapswipe-firefox branch October 7, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

@adube adube adube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RBcote @fredj @adube @sbrunner