Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix request abort #5225

Merged
merged 1 commit into from Oct 15, 2019
Merged

Fix request abort #5225

merged 1 commit into from Oct 15, 2019

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Oct 14, 2019

  • Don't cancel request when it's used in a checker.
  • Better fileMock.
  • Remove process.exit(2); in request finish.
  • Use https for wms.geo.admin.ch.
  • request.abort('aborted'); => request.abort('failed'); to have errors...

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrunner sbrunner changed the title Fix master for VD Fix request abort Oct 14, 2019
@sbrunner sbrunner requested a review from fredj October 14, 2019 11:33
@sbrunner sbrunner marked this pull request as ready for review October 14, 2019 11:33
@sbrunner sbrunner force-pushed the fix-vd branch 7 times, most recently from c4943da to 54895e2 Compare October 14, 2019 15:36
Don't cancel request when it's used in a checker
@sbrunner sbrunner merged commit 9b37f37 into master Oct 15, 2019
@sbrunner sbrunner deleted the fix-vd branch October 15, 2019 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants