Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

While filter is active, change toolbar icon #5233

Merged
merged 1 commit into from Oct 18, 2019

Conversation

adube
Copy link
Contributor

@adube adube commented Oct 17, 2019

In the "desktop" and "desktop_alt" applications, when there is an actual filter being set onto a layer in the filter tool, then change the icon of the filter in the toolbar.

This replaces the behaviour of having the background being changed instead.

Also, the icon is only changed while the filter is in action, where the background color was always there even if the filter was not active.

##Technical details

In order to do so, we look for the "gmfDataSourceBeingFiltered.dataSource" value, which is the data source being filtered and if it has filters, then its filterRules won't be null.

@adube adube requested review from sbrunner and fredj October 17, 2019 14:45
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbrunner
Copy link
Member

Looks good to me, @fredj do you want to have a look?

Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adube
Copy link
Contributor Author

adube commented Oct 18, 2019

Thanks!

@adube adube merged commit 37fd04a into master Oct 18, 2019
@adube adube deleted the gsgmf-1127-filter-active-icon branch October 18, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants