Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add translation for ng-options list #5244

Merged
merged 1 commit into from Oct 23, 2019
Merged

Add translation for ng-options list #5244

merged 1 commit into from Oct 23, 2019

Conversation

llienher
Copy link
Member

@llienher llienher self-assigned this Oct 23, 2019
sbrunner
sbrunner requested changes Oct 23, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should directly put a text in gettextCatalog.getString...

@llienher llienher force-pushed the GSGMF-1138_fix-translation-wms-import branch from a56f083 to bc407f5 Compare October 23, 2019 09:22
@llienher llienher merged commit 291e49b into 2.4 Oct 23, 2019
@llienher llienher deleted the GSGMF-1138_fix-translation-wms-import branch October 23, 2019 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@llienher @sbrunner