Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WMTS layers get metadata limits #5245

Merged
merged 2 commits into from Nov 5, 2019
Merged

WMTS layers get metadata limits #5245

merged 2 commits into from Nov 5, 2019

Conversation

RBcote
Copy link
Contributor

@RBcote RBcote commented Oct 23, 2019

When creating WMTS layer, the min/max resolutions are set as min/max resolutions metadata. In the desktop_alt application, the 'Alpine convention' layer has a minResolution of 10 and a maxResolution of 100.

@RBcote RBcote requested a review from adube October 23, 2019 17:51
github-actions[bot]
github-actions bot reviewed Oct 23, 2019
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples: https://camptocamp.github.io/ngeo/1043-wmts-layers-limits/examples/
API documentation: https://camptocamp.github.io/ngeo/1043-wmts-layers-limits/apidoc/

@RBcote RBcote changed the title 1043 WMTS layers get metadata limits 1043 WIP WMTS layers get metadata limits Oct 23, 2019
@RBcote RBcote changed the title 1043 WIP WMTS layers get metadata limits [WIP] WMTS layers get metadata limits Oct 23, 2019
adube
adube previously requested changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use the methods available in Themes.js instead:

getNodeMaxResolution
getNodeMinResolution

and also give opt_maxResolution and opt_minResolution as arguments for the method instead of opt_metadata

@fredj fredj changed the title [WIP] WMTS layers get metadata limits WMTS layers get metadata limits Nov 4, 2019
@sbrunner sbrunner added this to the 2.5 milestone Nov 4, 2019
@fredj fredj dismissed adube’s stale review November 5, 2019 08:55

getNode{Min,Max}Resolution are now used

@fredj fredj merged commit 93869fa into master Nov 5, 2019
@fredj fredj deleted the 1043-wmts-layers-limits branch November 5, 2019 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@fredj fredj fredj approved these changes

@sbrunner sbrunner sbrunner approved these changes

@adube adube adube left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RBcote @fredj @sbrunner @adube