Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink have the map swipe value. #5263

Merged
merged 3 commits into from Oct 30, 2019
Merged

Conversation

RBcote
Copy link
Contributor

@RBcote RBcote commented Oct 29, 2019

This patch introduce the value of the swiper into the permalink.
When the swiper being change, its value is set into the permalink. Refreshing this page and the swiper will be set at the same place. Remove it and refresh the page, the swiper will not appear.

@RBcote RBcote requested a review from adube October 29, 2019 18:13
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adube adube changed the title Permalink have the map swipe value. [WIP] Permalink have the map swipe value. Oct 29, 2019
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested: it's not working without the map_swipe_value parameter. Please, fix.

@RBcote RBcote requested a review from adube October 30, 2019 13:18
@adube adube changed the title [WIP] Permalink have the map swipe value. Permalink have the map swipe value. Oct 30, 2019
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working properly now.

@fredj Please review.

@adube adube requested a review from fredj October 30, 2019 14:01
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @RBcote

@RBcote RBcote merged commit 9721abb into master Oct 30, 2019
@sbrunner sbrunner deleted the 1121-permalink-state-swiper branch October 30, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants