Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces close button to the swiper #5275

Merged
merged 2 commits into from Nov 6, 2019
Merged

Conversation

RBcote
Copy link
Contributor

@RBcote RBcote commented Nov 4, 2019

This patch introduce the close button to the map swiper. By clicking on it, the swiper closes

@RBcote RBcote requested a review from adube November 4, 2019 18:30
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/map/swipe.js Show resolved Hide resolved
Copy link
Contributor

@adube adube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested - works properly.

Let's ask @fredj to do a review as well and merge this one accepted.

@adube adube changed the title [WIP] Introduces close button to the swiper Introduces close button to the swiper Nov 6, 2019
@adube adube requested a review from fredj November 6, 2019 14:42
src/map/swipe.js Show resolved Hide resolved
@fredj fredj merged commit 51c7e6c into master Nov 6, 2019
@fredj fredj deleted the 1140-close-button-swiper branch November 6, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants