Fix duplicate WMS query results #5283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
sbrunner
force-pushed
the
gsgmf-1143-query-result-duplicates
branch
from
0362ab9
to
2d9042b
Compare
|
@adube I rebase your branch to make the CI pass... |
|
Yeah, I was thinking about this fix yesterday evening, wondering if this was a typo or intentional. Turns out it seems to be intentional: with WMS, when using "group" names, the query asks for the group name but the result contains the layer name. Therefore, I think this is why the wfs layer names were added to the wms ones, but caused issues when the WMS layer doesn't use groups. I'll come with an other fix and make more tests. I'll also leave a comment there, to let devs know that this is not a typo, it is intentionnal. |
|
Thanks. Can I merge this, knowing that the demo is tomorrow? |
|
+1 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tiny patch fixes the duplicates that we had in the query results due to the fact that the WFS layers were not being pushed in the proper array.So, if the wms and wfs layers were the same, they were duplicated. In some cases, wms use a layer "group" as name, but wfs uses layer names, so this may explain why there were not duplicates sometimes.Update: This patch now properly fixes the listing of wms layer names to be used for query result.