Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading notifications #5304

Merged
merged 2 commits into from Dec 20, 2019
Merged

Loading notifications #5304

merged 2 commits into from Dec 20, 2019

Conversation

llienher
Copy link
Member

@llienher llienher commented Nov 15, 2019 •
edited

List of changes and status:

  • Application loading
  • Layer tree layer loading
  • Query grid component
  • Search (change icon to loading inside search field)
  • User login
  • Print just change the icon
  • Profile (make it stays opened and display loading icon)
  • Import layer
  • Shortener (when sending mail)

Out of scope (find alternative implementation) in another PR:

  • Query window component
  • Filter (for query, not get data)

@llienher llienher force-pushed the GSGMF-1049_loading-notifications branch from f72a8d7 to c016192 Compare November 26, 2019 08:19
@llienher llienher self-assigned this Dec 5, 2019
@llienher llienher force-pushed the GSGMF-1049_loading-notifications branch from 7e0eb9e to a9a6808 Compare December 18, 2019 15:28
@llienher llienher changed the title [wip] Loading notifications Loading notifications Dec 19, 2019
@llienher llienher marked this pull request as ready for review December 19, 2019 09:12
@llienher llienher force-pushed the GSGMF-1049_loading-notifications branch from a9a6808 to 11acd6b Compare December 19, 2019 11:39
@llienher
Copy link
Member Author

@sbrunner @fredj CI is fixed, ready for review.
PS: Note that two points are out of this PR, in a new dedicated ticket.

@sbrunner
Copy link
Member

Query grid component: no loading on firs query...
Profile: strange icon placement...

Also that's looks good :-)

sbrunner
sbrunner reviewed Dec 19, 2019
View reviewed changes
contribs/gmf/apps/desktop/index.html.ejs Outdated Show resolved Hide resolved
contribs/gmf/apps/desktop_alt/index.html.ejs Outdated Show resolved Hide resolved
contribs/gmf/src/controllers/AbstractDesktopController.js Outdated Show resolved Hide resolved
contribs/gmf/src/controllers/AbstractDesktopController.js Outdated Show resolved Hide resolved
contribs/gmf/src/search/search.scss Outdated Show resolved Hide resolved
@llienher
Add and unify loading notifications
65ef478 
Changes:
- layertree
- print
- elevation widget
- loading
- query grid component

Added:
- share component
- search input
- login/logout/pwd change
- KML import
- profile
@llienher llienher force-pushed the GSGMF-1049_loading-notifications branch from b5a9be1 to 65ef478 Compare December 19, 2019 16:33
@llienher
Copy link
Member Author

@sbrunner I removed commented code (but kept the spinner directive, even unused). Otherwise the last changes are moving back the spinner for profile at center and allowing the grid to open at first query, displaying the spinner.

@llienher llienher merged commit f01d6b3 into master Dec 20, 2019
@llienher llienher deleted the GSGMF-1049_loading-notifications branch December 20, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner left review comments

@fredj fredj fredj approved these changes

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@llienher @sbrunner @fredj