Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add css for gmf mobile fullscreen popups #535

Merged

Conversation

ger-benjamin
Copy link
Member

Ref to camptocamp/c2cgeoportal#1707

Example: https://ger-benjamin.github.io/ngeo/master/examples/contribs/gmf/apps/mobile/index.html
(watch it in theme edit, layer point (button metadata (i)))

Css for classic popups. Used to display metadata url popup from layertree (But not used in this the app mobile layertree because current demo uses an option to open links in a new page).

right: 50%;
max-height: 400px;
position: fixed;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation

@sbrunner
Copy link
Member

sbrunner commented Feb 3, 2016

Looks good for me

ger-benjamin added a commit that referenced this pull request Feb 4, 2016
Add css for gmf mobile fullscreen popups
@ger-benjamin ger-benjamin merged commit 6389715 into camptocamp:master Feb 4, 2016
@@ -0,0 +1,55 @@
[ngeo-popup] {
&.popover {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.popover is the class that defines the popup as full screen ?

@fgravin
Copy link
Member

fgravin commented Feb 4, 2016

The example is broken.

@ger-benjamin
Copy link
Member Author

Example on ger-benjamin.github.io ? normal I've changed my gh-pages after to have merge this PR...
And metadata opens in new windows in mobile layertree (set gmf-layertree-openlinksinnewwindow to false to watch the popup)

@ger-benjamin ger-benjamin deleted the gmf-metadata-popup-css branch March 15, 2016 13:56
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants