Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webpack comment, configuration #5357

Merged
merged 2 commits into from Dec 16, 2019
Merged

Webpack comment, configuration #5357

merged 2 commits into from Dec 16, 2019

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner added this to the 2.5 milestone Dec 13, 2019
gberaudo
gberaudo reviewed Dec 16, 2019
View reviewed changes
buildtools/webpack.commons.js
}),
new webpack.IgnorePlugin(/^\.\/locale$/, /node_modules\/moment\/src\/lib\/locale$/),
];
if (config.nodll != true) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a boolean?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boolean or undefined ...

@sbrunner sbrunner merged commit 96d0f55 into master Dec 16, 2019
@sbrunner sbrunner deleted the webpack branch December 16, 2019 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @gberaudo