Close associated popup submenu at layertree removal #5358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
llienher
force-pushed
the
GSGMF-1161_layertree-ui-fix
branch
from
35be35d
to
763ccd1
Compare
llienher
changed the title
llienher
changed the title
fredj
reviewed
Dec 17, 2019
fredj
reviewed
Dec 17, 2019
gberaudo
reviewed
Dec 18, 2019
llienher
force-pushed
the
GSGMF-1161_layertree-ui-fix
branch
from
763ccd1
to
df85528
Compare
llienher
force-pushed
the
GSGMF-1161_layertree-ui-fix
branch
from
df85528
to
50af5a1
Compare
gberaudo
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.camptocamp.com/browse/GSGMF-1161
This fix allows a node to be removed from layertree as well as its associated popup menu if existing.
I had to add a new ID to HTML element to easily find the attributes I needed to extract. Popup identifier is created randomly at each new opening and is not consistent when closing/opening the menu.
I added this popup identifer to a optional custom attribute in the GMF group and retrieve it when I want to target the existing popup.
I use UID over ID, as these last are duplicated when a single layer is in several groups loaded in the layertree. If I don't I'm not able to select the correct html element.