Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GMF profile tooltips #5375

Merged
merged 1 commit into from Dec 19, 2019
Merged

Fix GMF profile tooltips #5375

merged 1 commit into from Dec 19, 2019

Conversation

adube
Copy link
Contributor

@adube adube commented Dec 18, 2019

This patch fixes the GMF profile tooltips, which were not working since a regression was introduced in 6d38eed.

The extra "if" makes no sense there, because the code that would create the elements is inside the if and therefore no tooltips were ever created.

@adube adube requested a review from sbrunner December 18, 2019 19:17
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@adube adube merged commit ab3253f into master Dec 19, 2019
@adube adube deleted the gsgmf-1155-profile-tooltip-fix branch December 19, 2019 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants