[wip] mobile-query #540

adube · 2016-01-21T20:37:35Z

This PR introduces the query service and mobile-query directive.

It's still work in progress, so here's a check list of the items remaining to do to consider this task completed (I added what's already done as well):

The GeoJSON info format will not be added.

We will NOT add the query tool in the "mobile" example page as part of this task since the result is not yet completed.

Live examples

adube · 2016-01-21T20:52:13Z

@fgravin Here's a list of things I'd like you to check so far:

see the e-mail about the watchers - I would very much like to reduce their number
see if how I manage the activation of the directive is okay to you

adube · 2016-01-26T17:02:59Z

@fgravin: @pgiraud and I would like to talk to you about the "MobileQuery" directive and the way the activation works. If you recall correctly, we discussed about this and you introduced me to $scope.$watch. We would like to review this approach. I'll talk to you about this tomorrow.

adube · 2016-01-27T18:58:42Z

@fgravin Travis fails because of the template in contrib/gmf/examples/partials. I'm pretty sure it's because there's something missing in the Makefile to manage those.

adube · 2016-01-29T13:05:28Z

@fgravin You can look at the Travis error now. Thanks.

ger-benjamin · 2016-02-01T07:50:45Z

@adube When we create a directive in contrib/gmf we add (and use in our examples) a new default template located in the contribs/gmf/src/directive/partials folder. (Look at: https://github.com/camptocamp/ngeo/blob/master/contribs/gmf/src/directives/search.js#L18-L27 and https://github.com/camptocamp/ngeo/blob/master/contribs/gmf/src/directives/search.js#L66). And offer the possibility to override it.

I think that we should not create specific templates for gmf examples.

adube · 2016-02-01T13:54:42Z

@ger-benjamin, the directive is not agmf one, but rather a ngeo one. But, we need to have 2 examples because of the gmf.QueryManager service.

Both the examples in ngeo and gmf currently use a template that is in the example directory. The one in ngeo should stay there in my opinion because we don't plan to create a directive for the results in ngeo. For the one in gmf, we do so we could flush it. I don't think it's currently ready, though.

What should I do with this ? Could we talk about this ?

adube · 2016-02-01T15:05:50Z

FYI, it is as I suspected: there was something missing in the Makefile. Waiting for travis, but I expect it to build properly now.

fgravin · 2016-02-01T16:29:07Z

contribs/gmf/examples/partials/queryresult.html

+       no one-time binding here -->
+  <li ng-repeat="source in qrCtrl.result.sources"
+      role="presentation"
+      ng-if="source.features.length">


try a one time binding here

yeah, when doing that the result no longer shows. It needs to stick as it is.

fgravin · 2016-02-01T16:54:54Z

Some minor comments but it's globally excellent work.
Please see the comments and squash all commits in one.

I would like to have to links to the examples as well to see the result.

adube · 2016-02-01T19:14:18Z

@fgravin I need help for 2 issues in the 'builded' mode:

(minor issue) - how can I include the boostrap css file ? The hosted-example doesn't pick the one in lib, i.e. the path stays to ../node_modules/...
(major issue) - on click, I get an error from angular, which I have no clue what to do with. How can I debug this ?

TypeError: Cannot set property namespaceURI of #<Element> which has only a getter
    at py.kc (http://localhost:3000/.build/examples-hosted/lib/ngeo.js:690:139)
    at hu (http://localhost:3000/.build/examples-hosted/lib/ngeo.js:548:88)
    at py.l.Ha (http://localhost:3000/.build/examples-hosted/lib/ngeo.js:547:738)
    at oB.<anonymous> (http://localhost:3000/.build/examples-hosted/lib/ngeo.js:839:217)
    at Array.forEach (native)
    at oB.<anonymous> (http://localhost:3000/.build/examples-hosted/lib/ngeo.js:839:175)
    at http://localhost:3000/.build/examples-hosted/lib/angular.min.js:119:113
    at n.$eval (http://localhost:3000/.build/examples-hosted/lib/angular.min.js:133:221)
    at n.$digest (http://localhost:3000/.build/examples-hosted/lib/angular.min.js:130:233)
    at n.$apply (http://localhost:3000/.build/examples-hosted/lib/angular.min.js:133:512)

adube · 2016-02-02T18:47:51Z

About the above error, I create a PR in ol3: openlayers/openlayers#4772. I'll switch the ol3 version to use that branch to be able. Once merged, I'll go back to ol3#master

adube · 2016-02-03T13:32:44Z

Travis fails after I rebased onto master. I get the following errors (here's only the first few ones):

make dist
mkdir -p dist/
node buildtools/build.js .build/ngeo.json dist/ngeo.js
info ol Parsing dependencies
info ol Compiling 396 sources
ERR! compile /opt/ngeo/adube/src/directives/desktopgeolocation.js:124: ERROR - actual parameter 1 of goog.events.listen does not match formal parameter
ERR! compile found   : ol.Geolocation
ERR! compile required: (EventTarget|goog.events.Listenable|null)
ERR! compile       this.geolocation_,
ERR! compile       ^
ERR! compile 
ERR! compile 
ERR! compile /opt/ngeo/adube/src/directives/desktopgeolocation.js:134: ERROR - actual parameter 1 of goog.events.listen does not match formal parameter
ERR! compile found   : ol.Geolocation
ERR! compile required: (EventTarget|goog.events.Listenable|null)
ERR! compile       this.geolocation_,
ERR! compile       ^

Any idea where those come from ?

pgiraud · 2016-02-03T13:36:41Z

Not your fault. Master build is broken.
We're currently trying to fix this.

On Wed, Feb 3, 2016 at 2:32 PM, Alexandre Dubé notifications@github.com
wrote:

Travis fails after I rebased onto master. I get the following errors
(here's only the first few ones):

make dist
mkdir -p dist/
node buildtools/build.js .build/ngeo.json dist/ngeo.js
info ol Parsing dependencies
info ol Compiling 396 sources
ERR! compile /opt/ngeo/adube/src/directives/desktopgeolocation.js:124: ERROR - actual parameter 1 of goog.events.listen does not match formal parameter
ERR! compile found : ol.Geolocation
ERR! compile required: (EventTarget|goog.events.Listenable|null)
ERR! compile this.geolocation_,
ERR! compile ^
ERR! compile
ERR! compile
ERR! compile /opt/ngeo/adube/src/directives/desktopgeolocation.js:134: ERROR - actual parameter 1 of goog.events.listen does not match formal parameter
ERR! compile found : ol.Geolocation
ERR! compile required: (EventTarget|goog.events.Listenable|null)
ERR! compile this.geolocation_,
ERR! compile ^

Any idea where those come from ?

—
Reply to this email directly or view it on GitHub
#540 (comment).

Pierre GIRAUD
Géomaticien, Analyste

Camptocamp France SAS
Savoie Technolac, BP 352
73377 Le Bourget du Lac, Cedex

Tel : 00 33 4 79 44 44 93
Mail : pierre.giraud@camptocamp.com
http://www.camptocamp.com

adube · 2016-02-08T13:33:33Z

@fgravin This is ready to merge, once Travis passes.

fgravin · 2016-02-08T13:49:22Z

So it works on minified mode ?

adube · 2016-02-08T13:55:24Z

@fgravin Yes. See the live demos in the PR description, above.

fgravin · 2016-02-08T15:46:01Z

contribs/gmf/examples/mobilequery.js

+ * @param {gmf.Themes} gmfThemes The gme themes service.
+ * @param {gmf.QueryManager} gmfQueryManager The gmf query manager service.
+ */
+app.MainController = function(gmfThemes, gmfQueryManager) {


Where gmfQueryManager is used ?

It's required here. If we don't inject this, then it's not created and it doesn't do its magic.

fgravin · 2016-02-08T16:12:19Z

ngeo example doesn't work, CORS issue :/

adube · 2016-02-08T18:42:43Z

@fgravin I made the fix to use the new architecture of the ToolActivate, which is way more simpler now! Nice stuff.

I also updated the github.io pages.

Ready for merge, once Travis passes.

adube · 2016-02-08T18:50:15Z

ngeo example doesn't work, CORS issue :/

It does for me right now. Would you please check again ?

fgravin · 2016-02-08T20:37:10Z

Very good thanks

Add mobile-query

adube force-pushed the query branch 4 times, most recently from d3e7242 to bcb5d64 Compare January 26, 2016 14:09

adube force-pushed the query branch from c3b6986 to 049a298 Compare January 27, 2016 15:23

adube force-pushed the query branch from ee27187 to ac9b79e Compare January 28, 2016 13:34

adube force-pushed the query branch from 890c118 to 86e30db Compare February 1, 2016 15:01

fgravin reviewed Feb 1, 2016
View reviewed changes

adube force-pushed the query branch from 930c74e to 93aa97c Compare February 1, 2016 19:09

adube force-pushed the query branch 2 times, most recently from e19b3c9 to eca1ccc Compare February 3, 2016 13:25

jlap mentioned this pull request Feb 4, 2016

mobile-measure #518

Merged

16 tasks

adube force-pushed the query branch from eca1ccc to 50a1185 Compare February 4, 2016 16:10

adube force-pushed the query branch 2 times, most recently from 8768394 to 38de733 Compare February 8, 2016 13:32

fgravin reviewed Feb 8, 2016
View reviewed changes

adube force-pushed the query branch from 38de733 to ad2eae6 Compare February 8, 2016 18:39

Add mobile-query directive and query service

6ecc518

adube force-pushed the query branch from ad2eae6 to 6ecc518 Compare February 8, 2016 18:40

fgravin added a commit that referenced this pull request Feb 8, 2016

Merge pull request #540 from adube/query

879cf20

Add mobile-query

fgravin merged commit 879cf20 into camptocamp:master Feb 8, 2016

adube deleted the query branch February 9, 2016 16:26

sbrunner added this to the Older milestone Aug 23, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[wip] mobile-query #540

[wip] mobile-query #540

adube commented Jan 21, 2016

adube commented Jan 21, 2016

adube commented Jan 26, 2016

adube commented Jan 27, 2016

adube commented Jan 29, 2016

ger-benjamin commented Feb 1, 2016

adube commented Feb 1, 2016

adube commented Feb 1, 2016

fgravin Feb 1, 2016

adube Feb 1, 2016

fgravin commented Feb 1, 2016

adube commented Feb 1, 2016

adube commented Feb 2, 2016

adube commented Feb 3, 2016

pgiraud commented Feb 3, 2016

adube commented Feb 8, 2016

fgravin commented Feb 8, 2016

adube commented Feb 8, 2016

fgravin Feb 8, 2016

adube Feb 8, 2016

fgravin commented Feb 8, 2016

adube commented Feb 8, 2016

adube commented Feb 8, 2016

fgravin commented Feb 8, 2016

[wip] mobile-query #540

[wip] mobile-query #540

Conversation

adube commented Jan 21, 2016

Live examples

adube commented Jan 21, 2016

adube commented Jan 26, 2016

adube commented Jan 27, 2016

adube commented Jan 29, 2016

ger-benjamin commented Feb 1, 2016

adube commented Feb 1, 2016

adube commented Feb 1, 2016

fgravin Feb 1, 2016

Choose a reason for hiding this comment

adube Feb 1, 2016

Choose a reason for hiding this comment

fgravin commented Feb 1, 2016

adube commented Feb 1, 2016

adube commented Feb 2, 2016

adube commented Feb 3, 2016

pgiraud commented Feb 3, 2016

adube commented Feb 8, 2016

fgravin commented Feb 8, 2016

adube commented Feb 8, 2016

fgravin Feb 8, 2016

Choose a reason for hiding this comment

adube Feb 8, 2016

Choose a reason for hiding this comment

fgravin commented Feb 8, 2016

adube commented Feb 8, 2016

adube commented Feb 8, 2016

fgravin commented Feb 8, 2016