Revert regression in gmf print component #5448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
force-pushed
the
gsgmf-1195-print-panel-legend-checkbox-fix
branch
from
80feeba
to
d6e1fdc
Compare
adube
force-pushed
the
gsgmf-1195-print-panel-legend-checkbox-fix
branch
from
d6e1fdc
to
091a113
Compare
sbrunner
approved these changes
Jan 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression was introduced in the gmf print component by the following "auto-replace" commit: 6d38eed
The code it replaced broke the logic of how the legend in the print component is included. This patch reverts it to its original state, which restores the feature properly.