Fix Translate and Modify interactions #5479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug with Translate and Modify interactions in ngeo (regression introduced by: d207fc7)
In the setState methods of these interactions, both the map and active properties are checked to unregister events. An extra check was made for the map, and when falsy the method did nothing, while it had to (unregister events). The cause was that upon selecting a feature in the draw tool, new events were incrementing and the clicked features was being "selected" 1 extra time everytime, cummulatively.
This fixes this issue.
Also, I don't understand how it can be possible the the interactions and listenerKeys properties can be
undefinedwhen the method is called since they are initialized in the constructor, but they can! The extra "if" takes care of that very odd issue.