Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirect gmf example to https #548

Merged
merged 1 commit into from
Jan 26, 2016
Merged

Redirect gmf example to https #548

merged 1 commit into from
Jan 26, 2016

Conversation

sbrunner
Copy link
Member

@sbrunner
Copy link
Member Author

@@ -16,3 +16,11 @@ Navigator.prototype.systemLanguage;
* @type {string}
*/
Navigator.prototype.userLanguage;

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 blank lines?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@pgiraud
Copy link
Contributor

pgiraud commented Jan 26, 2016

With this pull request I can't test the hosted examples served with make serve anymore. Well I can if I use localhost. But this is not possible if I want to try on my device. In this case, I usually use a url like the following.
http://wrk31.wrk.cby.camptocamp.com:3000/.build/examples-hosted/contribs/gmf/apps/mobile/

In this case, I'm redirected to https which fails.

@sbrunner
Copy link
Member Author

@pgiraud I change to use the port to the the "serve" test :-)

@pgiraud
Copy link
Contributor

pgiraud commented Jan 26, 2016

Did you see my comment about the Location type?

@pgiraud
Copy link
Contributor

pgiraud commented Jan 26, 2016

Good for me. Please merge.

sbrunner added a commit that referenced this pull request Jan 26, 2016
Redirect gmf example to https
@sbrunner sbrunner merged commit 9567bcf into master Jan 26, 2016
@sbrunner sbrunner deleted the https branch January 26, 2016 12:39
@sbrunner
Copy link
Member Author

Thanks @pgiraud :-)

@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants