Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage map view rotation and map swipe #5490

Merged
merged 1 commit into from Feb 5, 2020
Merged

Manage map view rotation and map swipe #5490

merged 1 commit into from Feb 5, 2020

Conversation

adube
Copy link
Contributor

@adube adube commented Feb 4, 2020

Rotating the map while the map swipe component is active doesn't work well. This patch fixes this issue.

  • when the map gets rotated, the map swipe tool gets deactivated
  • when the map swipe tool gets activated, restore the rotation of the map

@adube adube requested review from fredj and sbrunner February 4, 2020 20:10
github-actions[bot]
github-actions bot reviewed Feb 4, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Examples: https://camptocamp.github.io/ngeo/gsgmf-1208-rotation-map-swipe/examples/
API documentation: https://camptocamp.github.io/ngeo/gsgmf-1208-rotation-map-swipe/apidoc/

sbrunner
sbrunner approved these changes Feb 5, 2020
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@adube adube merged commit 5c49a59 into master Feb 5, 2020
@adube adube deleted the gsgmf-1208-rotation-map-swipe branch February 5, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@sbrunner sbrunner sbrunner approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adube @sbrunner