Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix node menu in mobile layertree to open and close #5494

Merged
merged 1 commit into from Feb 7, 2020

Conversation

llienher
Copy link
Member

@llienher llienher commented Feb 6, 2020

https://jira.camptocamp.com/browse/GSGMF-1212

"Show" class was never applied... And I tried to put everything into the css files but that worked only using the inline "display: none" style, so I kept it that way...

Bootstrap 4 changes the "show"/"hide" classes to become:

The classes are named using the format:
- .d-{value} for xs
- .d-{breakpoint}-{value} for sm, md, lg, and xl.

Where value is one of:
- none
- inline
- inline-block
- block
- table
- table-cell
- table-row
- flex
- inline-flex

https://getbootstrap.com/docs/4.1/utilities/display/

@llienher llienher self-assigned this Feb 6, 2020
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bootstrap 4 use different names for classes to show and hide elements
@llienher llienher changed the title Set and remove corretly inline style when toggling node menu Fix node menu in mobile layertree to open and close Feb 6, 2020
@llienher llienher merged commit 1707c98 into master Feb 7, 2020
@llienher llienher deleted the GSGMF-1212_mobile-layertree branch February 7, 2020 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants