Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix legend show/collapse, and legend for QGIS #5517

Merged
merged 2 commits into from Feb 13, 2020

Conversation

adube
Copy link
Contributor

@adube adube commented Feb 12, 2020

Fixes the regression introduced in dd38023 that caused the show/hide to no longer works for any legend in the layer tree. (@llienher Please, check what I restored and see if/why the change was made).

Then, this patch also fixes the issue with QGIS legends. It was simply a matter of nothing being handled for them at all.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks :-)

Copy link
Member

@llienher llienher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it's looks good for the legends itself.
Just a comment about the mobile interface that maybe need to be fixed here or in another PR.

@adube adube merged commit 411cc91 into master Feb 13, 2020
@adube adube deleted the gsgmf-1210-legend-showhide-fix branch February 13, 2020 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants