Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show loading screen after login while themes are loading #5593

Merged
merged 2 commits into from Mar 10, 2020

Conversation

adube
Copy link
Contributor

@adube adube commented Mar 5, 2020

This patch introduces the following behaviour: In the "desktop" applications, after the user successfully logs in, the "login" panel will stay open until:

  • the login is successful (as before)
  • and after the new themes have been loaded (this is new)

Also, after loging in, while the new themes are being loaded, a message is shown in the login panel along with a spinner.

@adube adube requested review from sbrunner and llienher March 5, 2020 13:17
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adube adube requested a review from fredj March 5, 2020 13:23
@adube adube force-pushed the gsgmf-1227-login-load-panel branch from d70e007 to d1f9864 Compare March 10, 2020 15:25
@adube
Copy link
Contributor Author

adube commented Mar 10, 2020

Ready for review.

Copy link
Member

@llienher llienher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it looks good to me.

@adube adube merged commit 3531c93 into master Mar 10, 2020
@adube adube deleted the gsgmf-1227-login-load-panel branch March 10, 2020 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants