Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't crash when the profile return partial data #5606

Merged
merged 1 commit into from
Mar 11, 2020
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions contribs/gmf/src/profile/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -664,14 +664,14 @@ ProfileController.prototype.getZFactory_ = function(layerName) {
/**
* Generic GMF extractor for the 'given' value in 'values' in profileData.
* @param {Object} item The item.
* @return {number} The elevation.
* @return {number|null} The elevation or `null` if the value is not present in the data.
* @private
*/
const getZFn = function(item) {
if ('values' in item && layerName in item.values && item.values[layerName]) {
return parseFloat(item.values[layerName]);
}
return Number.NaN;
return null;
};
return getZFn;
};
Expand Down