Allow setting permalink zoom with map_zoom param #5684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
reviewed
Mar 31, 2020
src/statemanager/WfsPermalink.js
Outdated
| @@ -252,7 +260,7 @@ WfsPermalinkService.prototype.issueRequest_ = function(wfsType, filter, map, sho | |||
| // zoom to features | |||
| const size = map.getSize(); | |||
| if (size !== undefined) { | |||
| const maxZoom = this.pointRecenterZoom_; | |||
| const maxZoom = zoomLevel || this.pointRecenterZoom_; | |||
There was a problem hiding this comment.
Don't work with zoomLevel == 0...
There was a problem hiding this comment.
@svaabs Can you change it to this:
const maxZoom = zoomLevel !== undefined ? zoomLevel : this.pointRecenterZoom_;
|
@fredj does it look good to you? |
|
looks good to me |
|
@sbrunner review OK? (fredj wrote that it is OK for him) |
|
+1, merging :-) |
sbrunner
approved these changes
Apr 14, 2020
sbrunner
added a commit
that referenced
this pull request
Apr 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to set the zoom level with the parameter map_zoom in the URL for a WFS-Permalink.