Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the default theme configurable #575

Merged
merged 1 commit into from
Feb 3, 2016
Merged

Make the default theme configurable #575

merged 1 commit into from
Feb 3, 2016

Conversation

fredj
Copy link
Member

@fredj fredj commented Feb 1, 2016

Fixes #557

@fgravin
Copy link
Member

fgravin commented Feb 1, 2016

I think we were more talking about an angular.value in the index.html file, generated on page loading.

See https://github.com/Geoportail-Luxembourg/geoportailv3/blob/master/geoportailv3/templates/index.html#L275

@sbrunner
Copy link
Member

sbrunner commented Feb 1, 2016

Personally I think about this ...

@fgravin
Copy link
Member

fgravin commented Feb 1, 2016

What this ? the PR or my comment ?
Where the default theme will come from ? DB ?

@fredj
Copy link
Member Author

fredj commented Feb 1, 2016

What about adding a defaultTheme in the response from the 'themes' webservice?

@sbrunner
Copy link
Member

sbrunner commented Feb 1, 2016

this => the Pull request :-)

@sbrunner
Copy link
Member

sbrunner commented Feb 1, 2016

In standard case it's a configuration from the viewer.js.

@fgravin
Copy link
Member

fgravin commented Feb 1, 2016

Ok i don't mind.

sbrunner
sbrunner reviewed Feb 3, 2016
View reviewed changes
contribs/gmf/src/directives/themeselector.js
@@ -18,6 +18,7 @@ gmf.themeselectorDirective = function() {
restrict: 'E',
controller: 'gmfThemeselectorController',
scope: {
'defaultTheme': '@gmfThemeselectorDefaulttheme',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @htmlAttribute should be added, see: https://github.com/camptocamp/ngeo/blob/master/contribs/gmf/src/directives/search.js#L47-L50

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then for me you can merge :-)

@fredj fredj mentioned this pull request Feb 3, 2016
Closed
fredj added a commit that referenced this pull request Feb 3, 2016
@fredj
Merge pull request #575 from camptocamp/default_theme
5f725f0 
Make the default theme configurable
@fredj fredj merged commit 5f725f0 into master Feb 3, 2016
@fredj fredj deleted the default_theme branch February 3, 2016 11:19
@sbrunner
Copy link
Member

sbrunner commented Feb 3, 2016

Thanks :-)

@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Older
Development

Successfully merging this pull request may close these issues.

The default theme should be configurable
3 participants
@fredj @fgravin @sbrunner