Profile: allow changing scales from application code #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We used to provide two options: yLowerBound and ratioXYRule to allow applications to change the Y domain of the profile. This allowed enforcing rules like: min y value > 0 or a specific aspect ratio. It was not working so well though since the ratioXYRule signature was too restricted (only taking a xDomainMax) which could lead to ugly results. In this commit, these options are replaced by a more powerful option.
|
LGTM |
|
Thanks for the review @fredj. |
gberaudo
added a commit
that referenced
this pull request
Feb 2, 2016
Profile: allow changing scales from application code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We used to provide two options: yLowerBound and ratioXYRule to allow
applications to change the Y domain of the profile. This allowed enforcing
rules like: min y value > 0 or a specific aspect ratio.
It was not working so well though since the ratioXYRule signature was too
restricted (only taking a xDomainMax) which could lead to ugly results.
In this commit, these options are replaced by a more powerful option.