Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be able to change everything what we needs in the application #581

Merged
merged 2 commits into from
Feb 3, 2016

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Feb 2, 2016

fix [#558]

@sbrunner sbrunner added this to the 2.0 milestone Feb 2, 2016
@sbrunner sbrunner force-pushed the expandable-controllers branch 4 times, most recently from a010a63 to d952603 Compare February 2, 2016 15:41
pinchRotate: false,
altShiftDragRotate: false
})
});

// TODO: Remove when we add the base layer switcher
var parser = new ol.format.WMTSCapabilities();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just for information (because that's a "remove-me code block"), you can do the same with https://github.com/camptocamp/ngeo/blob/master/src/services/layerHelper.js#L107

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will not change it because for that we needs a temporary injection ...

@ger-benjamin
Copy link
Member

Good, but I don't really like to have a ~"global value" that is named Config. Don't you think that something like GmfConfig is better ?

@sbrunner
Copy link
Member Author

sbrunner commented Feb 3, 2016

It's not a global think that can be injected, it's just a type ...

@sbrunner sbrunner closed this Feb 3, 2016
@sbrunner sbrunner reopened this Feb 3, 2016
sbrunner added a commit that referenced this pull request Feb 3, 2016
Be able to change everything what we needs in the application
@sbrunner sbrunner merged commit 5793f04 into master Feb 3, 2016
@sbrunner sbrunner deleted the expandable-controllers branch February 3, 2016 15:30
@sbrunner sbrunner restored the expandable-controllers branch February 4, 2016 09:54
@sbrunner sbrunner deleted the expandable-controllers branch February 4, 2016 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants