Can disable search actions #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
disable_search_actions
branch
from
bdaf0c3
to
fcba8c1
Compare
|
up |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #868
Example 1:
Config: Any filter, any actions. Search will give you as well for 'osm' layers that for 'district' layer but not for groups or theme (actions)... ). Selecting an osm layer that have "add_layer" action will not add this layer (only recenter).
Link: https://ger-benjamin.github.io/ngeo/disable_search_actions/examples/contribs/gmf/apps/mobile/index.html
Example 2:
Config: filters: 'osm', 'district'. Actions: 'add_theme', 'add_group', 'add_layer'. You can search only for 'osm' and 'district' layers. You can also search for theme, groups and layers... (actions). Selecting an osm layer that have "add_layer" action will add this layer and recenter.
Link: https://ger-benjamin.github.io/ngeo/disable_search_actions/examples/contribs/gmf/apps/desktop/index.html
Please review.