Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard design for layertree #991

Merged

Conversation

olivierSemet
Copy link
Contributor

Following the spec #1708

  • Adding the desktop layertree design
  • Splitting layertree.less in 3 files in order to have a different design for mobile/desktop with a common base style
  • Refactoring selectors for the future needs (e.g for Defninir l'ordre #819 )

@olivierSemet
Copy link
Contributor Author

ping @pgiraud

@pgiraud
Copy link
Contributor

pgiraud commented Apr 6, 2016

Comments about the visual aspect first.

  • There is extra space above the first group.
    screenshot from 2016-04-06 14 03 42
  • The scrollbar is too close to the groups. This is not pretty.

screenshot from 2016-04-06 14 05 25

  • Can you make it so the collapse/expand icons are less visible (lighter gray)? The group name is more important than the chevron.
    screenshot from 2016-04-06 14 08 24 vs. screenshot from 2016-04-06 14 08 34
  • Can you give a try at using smaller size for child nodes? The goal is to emphasize the parent/child relationship. Not sure it's useful, but it's worth trying.

screenshot from 2016-04-06 14 11 54 vs. screenshot from 2016-04-06 14 11 41

&.depth-1 {
//styling first level node for desktop app
background-color: @nav-bg;
box-shadow: 1px 1px 4px 0 @input-border-focus, -1px -1px 1px 0 @input-border-focus;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason why you use 2 different shadows?

What about using the following?

box-shadow: 0 0 4px 1px @input-border-focus;

@olivierSemet olivierSemet force-pushed the add-standard-design-for-layertree branch 3 times, most recently from 20c2deb to 4b8cf7c Compare April 7, 2016 08:08
ul {
padding-top: @micro-app-margin;
}
> :first-child{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a space before curly brace (for consistency).

@olivierSemet olivierSemet force-pushed the add-standard-design-for-layertree branch from 4b8cf7c to 6d38797 Compare April 7, 2016 12:25
@pgiraud
Copy link
Contributor

pgiraud commented Apr 7, 2016

Looks good to me. Please merge.

@pgiraud pgiraud merged commit ba4f2d9 into camptocamp:master Apr 7, 2016
@olivierSemet olivierSemet deleted the add-standard-design-for-layertree branch May 9, 2016 17:39
@sbrunner sbrunner added this to the Older milestone Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants