Fix puppet error if the account is not yet created #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well if you can point what's going wrong with CI as well i'll be thankfull. (Well seems to fail on master branch as well so it's not really an issue...) |
| @@ -133,6 +133,7 @@ | |||
| exec { "put ssh private key ${name} for user ${user}": | |||
| command => "/bin/echo '${::accounts::ssh_keys[$name]['private']}' > ~${user}/.ssh/id_rsa; /bin/chown ${user} ~${user}/.ssh/id_rsa; /bin/chmod 600 ~${user}/.ssh/id_rsa", | |||
| unless => "/usr/bin/test -f ~${user}/.ssh/id_rsa", | |||
| onlyif => "/usr/bin/test -d ~${user}/.ssh", | |||
There was a problem hiding this comment.
or maybe manage the dir as a file resource? @mcanevet ?
nettucu
added a commit
to nettucu/puppet-accounts
that referenced
this pull request
Aug 9, 2019
* upstream/master: (21 commits) Release 1.11.1 Allow augeasproviders_shellvar 4 Fix tests on Puppet 6 msync Prepare release 1.11.0 Allow stdlib 5 & 6 Correcting issue camptocamp#15 (camptocamp#56) Fix puppet error if the account is not yet created (camptocamp#41) Allow augeasproviders_shellvar 3.x Add additional prerequisite (camptocamp#53) added expiry parameter (camptocamp#55) Merge group arrays instead of rightmost precedence (camptocamp#65) Allow ssh_options for accounts being created through accounts::usergroups as well (camptocamp#66) Use loop instead of recursion Fixes camptocamp#61 - Pass through managehome on absent Do not use legacy puppet-lint-absolute_classname-check plugin Fix beaker version to ~>3.13 Update to add the system option to account.pp Update with modulesync Release 1.10.0 ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there ;)
I had an error when pushing accounts through hiera and providing a private key... It generates an error when creating the private key as the user home folder doesn't exist at the time the command is run. It would be better with a require but I don't know how to require a resource from a custom module. At least this patch avoid any errors and deploy the private key at next run.
Tell me what you think about this one... Is it possible to do this with a require?