Skip to content

Commit

Permalink
Fix problem where a nodes details wouldn't load/show in puppet-catalo…
Browse files Browse the repository at this point in the history
…g-diff-viewer when the JSON-file is generated on a Puppet Master that has server configuration config_version set to generate Epoch numbers. In this case these numbers where stored as numbers instead of strings in the JSON-file which caused puppet-catalog-diff-viewer to throw an exception when it tries to replace strange characters in the version string. I've verified this works in latest version of puppet-catalog-diff-viewer. See also conversation on #puppet here https://puppetcommunity.slack.com/archives/C0W298S9G/p1594642754396700.
  • Loading branch information
JohnEricson committed Jul 13, 2020
1 parent 7238fc4 commit 90ab96e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions lib/puppet/catalog-diff/differ.rb
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,8 @@ def diff(options = {})
titles[:from] = extract_titles(from)

output = {}
output[:old_version] = from_meta[:version]
output[:new_version] = to_meta[:version]
output[:old_version] = from_meta[:version].to_s
output[:new_version] = to_meta[:version].to_s

output[:old_environment] = from_meta[:environment]
output[:new_environment] = to_meta[:environment]
Expand Down

0 comments on commit 90ab96e

Please sign in to comment.