Use ensure_packages instead of virtual resources #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcanevet
force-pushed
the
dev/no_virtual_packages
branch
from
a7eaaba
to
17ee3df
Compare
|
+1 for removing the use of virtual packages, if there's a valid alternative (never heard of |
mcanevet
force-pushed
the
dev/no_virtual_packages
branch
from
17ee3df
to
83e76de
Compare
|
@mfournier I'd say >= 4.2.0 as we need the option hash as a second parameter: https://github.com/puppetlabs/puppetlabs-stdlib/blob/master/CHANGELOG.md#2014-05-08---release---420 |
|
Thanks for taking care of this @mcanevet ! |
mfournier
pushed a commit
that referenced
this pull request
Jun 19, 2015
Use ensure_packages instead of virtual resources
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.