Config file support #64
Conversation
AndresCidoncha
force-pushed
the
config_file_support
branch
from
4283e28
to
d98bd9e
Compare
|
Baller pull request. Let me look at what you have done. |
|
@andrescidooncha did you include the TF0.12 enablement? |
|
I'd check out this branch from master. Do you mean these changes? #62 |
|
@AndresCidoncha thanks for these changes. There's quite a few (good) things in here, and I would rather not squash everything together. Do you think you could squash these into a couple of well-defined feature commits? |
|
Sure! I'll do ASAP |
|
@AndresCidoncha Note I just merged #62 (finally!) so you'll need to rebase (incl switching to go modules) |
AndresCidoncha
force-pushed
the
config_file_support
branch
from
6368918
to
f05a5d1
Compare
|
@raphink I merged your changes and I also fixed the problem with |
AndresCidoncha
force-pushed
the
config_file_support
branch
from
f05a5d1
to
3f11e99
Compare
|
@AndresCidoncha thanks. There seems to be conflicts still, can you check? |
|
@raphink I can't see the conflicts 😕 The change list seems to be ok, and GitHub say: |
|
Weird…
|
|
Yep, really weird: |
|
Maybe is due to trying to rebase instead of merge? As we don't have permission to merge, maybe github is showing the checks to merge, not rebase. |
|
Ah right, merging is possible, just not rebasing. |
|
@raphink You tell me rebase and I merge your changes. My bad. I'll have to fix it 😢 |
feat: Add base_url as config parameter refactor: Move S3/DynamoDB configs in AWS Config block doc: add example configuration file fix: fix auth module tests fix: remove debug print
* Now it's more readable * Also add test for SetBasePath method * Fix dependent tests
Avoid dependencies and executable in git Add vendor/ and terraboard to .gitignore
* Move Port to Web param group * Add ENV option to Port * Remove default value from config-file doc: Update readme * Add parameters to README Add LoadConfigFromYaml tests * db_port as uint16 * remove parameter from LoadConfigFromYaml method refactor: Use config.DBConfig as parameter in db.Init Sync interval configuration doc: Update README for sync-interval config * Use sync-interval in retry sleep too
AndresCidoncha
force-pushed
the
config_file_support
branch
from
3f11e99
to
b866010
Compare
I simply add the option of using a YAML file for configuring the service. Configurations loaded from file have the highest priority over others methods (cli params, env variables).
My idea is made multiples PR for achieving the multiple bucket configuration feature.