Multi-language support for simple values #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bleauxModel (dependency needed because of "completetable"-feature)
| @@ -135,7 +135,7 @@ class MediaController(override val config: TableauxConfig, | |||
| _ <- { | |||
| import FutureUtils._ | |||
| promisify({ p: Promise[Unit] => | |||
| vertx.fileSystem.delete(path.toString(), {result => p.success()}) | |||
| vertx.fileSystem.delete(path.toString(), {result => p.success(())}) | |||
There was a problem hiding this comment.
What happens if fileSystem.delete fails? Shouldn't it check the result and make a p.success()/p.failure()?
| p.success() | ||
| }) | ||
| // succeed also in error cause (directory already exists) | ||
| vertx.fileSystem.mkdir(s"$uploadsDirectory", { result => p.success() }) |
There was a problem hiding this comment.
You might not have all permissions to create this directory, so it's not always only "directory already exists". Maybe it's a special exception (EEXISTS) that can be checked against and succeed in that special case.
|
closes #54 |
alexvetter
added a commit
that referenced
this pull request
Jul 28, 2015
Multi-language support for simple values
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.