Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate Jobs Request scheduled Timer is not canceled on error #8423

Closed
romansmirnov opened this issue Dec 17, 2021 · 0 comments · Fixed by #8424
Closed

Activate Jobs Request scheduled Timer is not canceled on error #8423

romansmirnov opened this issue Dec 17, 2021 · 0 comments · Fixed by #8424
Assignees
@romansmirnov
Labels
kind/bug Categorizes an issue or PR as a bug scope/gateway Marks an issue or PR to appear in the gateway section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0

Comments

@romansmirnov
Copy link
Member

romansmirnov commented Dec 17, 2021 •
edited
Loading

Describe the bug

When long polling activate jobs request completes with an error, the corresponding scheduled timer is not canceled.

To Reproduce

  1. Submit an activate jobs request (with a request timeout)
  2. Prevent the request to be repeated afters its execution
  3. Execute the actual request from the gateway to the broker
  4. Ensure that no jobs get activated so that the request is enqueued for later (in this step a timer gets scheduled)
  5. Trigger second execution of the request (by notifying the gateway about newly available jobs, executing another request that activates jobs successfully, or executing probe)
  6. Let the request fail (either with a BrokerRejectionExcpetion or with resource exhausted)

Expected behavior

  • The scheduled timer is canceled on any error

Environment:

  • Zeebe Version: 1.2.7
  • Configuration: Enable Long Polling

is related to #8310
@romansmirnov romansmirnov added kind/bug Categorizes an issue or PR as a bug severity/low Marks a bug as having little to no noticeable impact for the user scope/gateway Marks an issue or PR to appear in the gateway section of the changelog labels Dec 17, 2021
@romansmirnov romansmirnov self-assigned this Dec 17, 2021
@romansmirnov romansmirnov added this to In progress in Zeebe Dec 17, 2021
@romansmirnov romansmirnov mentioned this issue Dec 17, 2021
Merged
9 tasks
@romansmirnov romansmirnov moved this from In progress to Review in progress in Zeebe Dec 17, 2021
@ghost ghost closed this as completed in a3dfe67 Dec 20, 2021
Zeebe automation moved this from Review in progress to Done Dec 20, 2021
This was referenced Dec 20, 2021
Merged
Merged
ghost pushed a commit that referenced this issue Dec 20, 2021
@romansmirnov
merge: #8444
5e931ec 
8444: [Backport stable/1.2] fix(polling): cancel scheduled timer on error r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8424 to `stable/1.2`.

relates to #8423

Co-authored-by: Roman <roman.smirnov@camunda.com>
ghost pushed a commit that referenced this issue Dec 20, 2021
@romansmirnov
merge: #8443
913e0e5 
8443: [Backport stable/1.1] fix(polling): cancel scheduled timer on error r=oleschoenburg a=github-actions[bot]

# Description
Backport of #8424 to `stable/1.1`.

relates to #8423

Co-authored-by: Roman <roman.smirnov@camunda.com>
@korthout korthout added the version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0 label Jan 4, 2022
@KerstinHebel KerstinHebel removed this from Done in Zeebe Mar 23, 2022
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@romansmirnov romansmirnov

Labels
kind/bug Categorizes an issue or PR as a bug scope/gateway Marks an issue or PR to appear in the gateway section of the changelog severity/low Marks a bug as having little to no noticeable impact for the user version:1.3.0 Marks an issue as being completely or in parts released in 1.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(polling): cancel scheduled timer on error camunda/camunda
3 participants
@menski @romansmirnov @korthout