Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile contains namespace #6118

Merged
merged 2 commits into from Jan 18, 2021
Merged

Makefile contains namespace #6118

merged 2 commits into from Jan 18, 2021

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Jan 15, 2021

Description

Since it happens to me quite often that I mistakenly delete or create resources in not the correct namespace. I added now the namespace to the makefile. Let me know what you think about that.

We can also discuss whether we want to still change the namespace or not.

Related issues

closes #

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@Zelldon Zelldon requested a review from npepinpe January 15, 2021 14:57
Copy link
Member

@npepinpe npepinpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, I also often have the same issue. It could also be solved by using something like direnv, but it's dangerous since it still changes your for other shells. One alternative is to look into kubie and set the config files for this - but I wouldn't do this now anyway.

One small suggestion but I don't consider it a blocker, you could extract the namespace to a variable: this has the advantage of only having to substitute a single thing, and also people can overwrite it via env vars if ever needed. But I'm also fine with how it is now.

@Zelldon
Copy link
Member Author

Zelldon commented Jan 18, 2021

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Jan 18, 2021

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 9ab280f into develop Jan 18, 2021
@zeebe-bors zeebe-bors bot deleted the zell-make-ns branch January 18, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants