Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 0.26] Use always new appender #6426

Merged
merged 2 commits into from Feb 24, 2021
Merged

Conversation

Zelldon
Copy link
Member

@Zelldon Zelldon commented Feb 23, 2021

Description

Backports #6392

Previous if the leader close transition took to long and the broker become leader again it could happen that the new appender was used by the old log storage appender. This is now prevented by not using a supplier. It requests the appender once on leader transition and always uses the same object.

@deepthidevaki you mentioned that you want to prevent stuff based on different term. I think it is already something checked in the ZeebePartition regarding that. If this is not enough for your we can create a follow up issue.

There were some changes necessary since here the journal changes are not available, which means we need to use the ZeebeIndexMapping etc.

Related issues

closes #6346

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

 * Previous if the leader close transition took to long and the broker become leader again it could happen that the new appender was used by the old log storage appender
@Zelldon Zelldon changed the title Zell backport 26 6346 [Backport 0.26] Use always new appender Feb 23, 2021
@Zelldon Zelldon changed the base branch from develop to stable/0.26 February 23, 2021 14:53
Copy link
Contributor

@deepthidevaki deepthidevaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Zelldon
Copy link
Member Author

Zelldon commented Feb 24, 2021

bors r+

@zeebe-bors
Copy link
Contributor

zeebe-bors bot commented Feb 24, 2021

Build succeeded:

@zeebe-bors zeebe-bors bot merged commit 988adf7 into stable/0.26 Feb 24, 2021
@zeebe-bors zeebe-bors bot deleted the zell-backport-26-6346 branch February 24, 2021 09:57
github-merge-queue bot pushed a commit that referenced this pull request Mar 14, 2024
* build: add spotless google java fmt

* refactor(schema): apply google java style

* refactor(qa): apply google java style

* refactor(archiver): apply google java style

* refactor(importer): apply google java style

* refactor(common): apply google java style

* refactor(data-generator): apply google java style

* refactor(importer-8_4): apply google java style

* refactor(importer-8_5): apply google java style

* refactor(importer-common): apply google java style

* refactor(webapp): apply google java style

* fix: remove extract semicolon

* refactor(qa): apply google java style

* feat: add intellij settings

To follow Zeebe guidelines adds intellij coding style configs
See https://github.com/camunda/zeebe/wiki/Code-Style#integration-with-intellij

* refactor: create profiles for spotless

 * New profile which is always active to reformat code
 * New profile to allow to check and validate code style; useful for CI

* ci: add format check job

Add additional step in the backend
-linting workflow to verify the
Google java checks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LogStorageAppender should use the LeaderRole from correct term
3 participants