Provide a way to get the parent scope key of a variable scope #6448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR currently includes commits from #6446 as it builds on top of it - it'll probably be easier to review once that one is merged. |
9 tasks
- exposes getParentScopeKey to the outside world - adds test cases - renames VariablesState to VariableState to align with other interfaces such as MutableVariableState
npepinpe
force-pushed
the
6175-parent-scope
branch
from
bcf7ddb
to
17acbf9
Compare
|
bors r+ |
|
Build succeeded: |
zeebe-bors bot
added a commit
that referenced
this pull request
Feb 26, 2021
6449: Allow detecting if a variable is declared locally in a given scope r=npepinpe a=npepinpe ## Description This PR adds `hasVariableLocal` to `VariableState`. This will allow us to extract a document merging behaviour - when propagating the merge, we need to know if a given scope already declares a variable or not (to know if we need to propagate it further). ## Related issues related to #6175 blocked by #6448 ## Definition of Done _Not all items need to be done depending on the issue and the pull request._ Code changes: * [x] The changes are backwards compatibility with previous versions * [ ] If it fixes a bug then PRs are created to [backport](https://github.com/zeebe-io/zeebe/compare/stable/0.24...develop?expand=1&template=backport_template.md&title=[Backport%200.24]) the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. `backport stable/0.25`) to the PR, in case that fails you need to create backports manually. Testing: * [x] There are unit/integration tests that verify all acceptance criterias of the issue * [x] New tests are written to ensure backwards compatibility with further versions * [x] The behavior is tested manually * [ ] The change has been verified by a QA run * [ ] The impact of the changes is verified by a benchmark Documentation: * [ ] The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.) * [ ] New content is added to the [release announcement](https://drive.google.com/drive/u/0/folders/1DTIeswnEEq-NggJ25rm2BsDjcCQpDape) Co-authored-by: Nicolas Pépin-Perreault <nicolas.pepin-perreault@camunda.com>
kristinkomschow
added a commit
that referenced
this pull request
Mar 15, 2024
* removed tenant check in ProcessStore calls * changed used client from tenant aware to high level client in DecisionStores * adjusted related test to mock high level client
kristinkomschow
added a commit
that referenced
this pull request
Mar 20, 2024
* removed tenant check in ProcessStore calls * changed used client from tenant aware to high level client in DecisionStores * adjusted related test to mock high level client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #6175, we will need a way to walk the scope hierarchy of variable scopes in order to properly merge variable documents, and this will be done outside of the
VariableState. The simplest solution is simply to exposegetParentScopeKeywhich returns either the parent scope key, orNO_PARENTif there is none.If we end up walking this hierarchy a lot, then we could always introduce a more complex abstraction, but this is fine for now.
Related issues
related to #6175
blocked by #6446
Definition of Done
Not all items need to be done depending on the issue and the pull request.
Code changes:
backport stable/0.25) to the PR, in case that fails you need to create backports manually.Testing:
Documentation: