[Backport stable/0.26] Test that a new incident is created when resolve incident fails to continue the processing #7139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pihme
approved these changes
May 27, 2021
| .startEvent() | ||
| .serviceTask( | ||
| "task", | ||
| b -> b.zeebeJobType("task").zeebeInputExpression("unknown_var", "output")) |
There was a problem hiding this comment.
Like I mentioned in the other review, the input variable is still called output
There was a problem hiding this comment.
Oh wow, I thought you meant the comment 😨
There was a problem hiding this comment.
Fixed here (I'll also update the others)
korthout
changed the title
As part of 7127, I investigated failure cases of resolving an incident. This test makes sure that continuation failure for the resolution of an incident leads to a new incident. (cherry picked from commit bf11019, with modifications)
korthout
force-pushed
the
backport-7130-to-stable/0.26
branch
from
398db93
to
e2e77d7
Compare
|
bors merge |
ghost
pushed a commit
that referenced
this pull request
May 27, 2021
7139: [Backport stable/0.26] Test that a new incident is created when resolve incident fails to continue the processing r=korthout a=korthout # Description Backport of #7130 to `stable/0.26`. relates to #7127 Modifications were necessary to resolve the conflicts (i.e. naming changes from 0.26 to 1.0.0). Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
9 tasks
|
Build failed: |
Flaky test bors retry |
ghost
pushed a commit
that referenced
this pull request
May 27, 2021
7140: test(engine): use correct input expression target r=pihme a=korthout ## Description <!-- Please explain the changes you made here. --> I missed a review comment in #7130. It came back up in [a review comment](#7139 (comment)) on the manual backport PR. This fixes it for the develop branch. ## Related issues <!-- Which issues are closed by this PR or are related --> relates to #7127 Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
|
Build succeeded: |
ghost
merged commit
ghost
pushed a commit
that referenced
this pull request
May 27, 2021
7140: test(engine): use correct input expression target r=pihme a=korthout ## Description <!-- Please explain the changes you made here. --> I missed a review comment in #7130. It came back up in [a review comment](#7139 (comment)) on the manual backport PR. This fixes it for the develop branch. ## Related issues <!-- Which issues are closed by this PR or are related --> relates to #7127 Co-authored-by: Nico Korthout <nico.korthout@camunda.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #7130 to
stable/0.26.relates to #7127
Modifications were necessary to resolve the conflicts (i.e. naming changes from 0.26 to 1.0.0).