Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nightly QA run for stable/0.26 #7238

Merged
1 commit merged into from
Jun 10, 2021

Conversation

korthout
Copy link
Member

@korthout korthout commented Jun 9, 2021

Description

The QA run can be run against a generation version of choice when running using the Build with parameters. This version specifies which versions of other components to spin up next to Zeebe as part of the Camunda Cloud cluster. For the nightly QA run, a default generation is provided in the Jenkinsfile which is statically defined and not automatically updated.

The currently used generation Zeebe 0.26.1 is no longer available and should be replaced by Zeebe 0.26.4.

This PR fixes the nightly QA runs against the stable/0.26 branch by switching to this newer generation version.

Related issues

closes #7237

Definition of Done

Not all items need to be done depending on the issue and the pull request.

Code changes:

  • The changes are backwards compatibility with previous versions
  • If it fixes a bug then PRs are created to backport the fix to the last two minor versions. You can trigger a backport by assigning labels (e.g. backport stable/0.25) to the PR, in case that fails you need to create backports manually.

Testing:

  • There are unit/integration tests that verify all acceptance criterias of the issue
  • New tests are written to ensure backwards compatibility with further versions
  • The behavior is tested manually
  • The change has been verified by a QA run
  • The impact of the changes is verified by a benchmark

Documentation:

  • The documentation is updated (e.g. BPMN reference, configuration, examples, get-started guides, etc.)
  • New content is added to the release announcement

@korthout korthout requested a review from pihme June 9, 2021 14:38
@korthout
Copy link
Member Author

korthout commented Jun 9, 2021

@pihme please have a look. I'd love to find a better solution to this (i.e. not defining it explicitly in the Jenkinsfile), but I have not yet found how to do it. If you have ideas, please share.

EDIT: It also seems the daily runs are enabled again on both 1.0 and 0.26 which are unaffected by this

Copy link
Contributor

@pihme pihme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@ghost
Copy link

ghost commented Jun 10, 2021

Build succeeded:

@ghost ghost merged commit b352480 into stable/0.26 Jun 10, 2021
@ghost ghost deleted the korthout-update-default-generation-version branch June 10, 2021 07:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants